Fix JSON component composed bundling#563
Merged
daveshanley merged 1 commit intopb33f:mainfrom Apr 30, 2026
Merged
Conversation
Contributor
Author
|
Hmmm, bundler tests pass locally. Let me have a look at what the issue is Edit: Looks like some Digital Ocean file can't be found? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 261 261
Lines 29615 29620 +5
=======================================
+ Hits 29523 29528 +5
Misses 55 55
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Digital ocean + github = a bad time 60% of the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #562
Fixes an issue in the component type detection mechanism that incorrectly ignores quoted keys (for escaping openapi keywords) in JSON components where every key must be quoted.
Let me know if you want any changes :)